Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop simulation on closing debugger tab #1661

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

brusherru
Copy link
Contributor

There is no issue 😬

@brusherru brusherru self-assigned this Feb 4, 2019
@brusherru brusherru force-pushed the fix-stop-simulation-on-debugger-close branch from 9752fec to 22e7aea Compare February 4, 2019 16:43
@brusherru
Copy link
Contributor Author

@nkrkv added two more middlewares and decoupled simulation from middleware about stop debug session. Check it out, please

Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flat, clear, nice 👍

@brusherru brusherru merged commit 5dd8648 into master Feb 5, 2019
@brusherru brusherru deleted the fix-stop-simulation-on-debugger-close branch February 5, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants